[FOUND-112] Close sockets on Timeout::Error within #get_multi#33
Open
mattwd7 wants to merge 2 commits intobraze-mainfrom
Open
[FOUND-112] Close sockets on Timeout::Error within #get_multi#33mattwd7 wants to merge 2 commits intobraze-mainfrom
mattwd7 wants to merge 2 commits intobraze-mainfrom
Conversation
…n a dirty socket, so the change is pointless
mattwd7
changed the title
pcalcado
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20 covers corruption caused by
Timeout::Errorwhich is raised during aserver.requestby closing the open socket and not leaving stale data for the next operation. It does not coverTimeout::Errorraised during aget_multi. This is b/cget_multicallsperformwith a block, causingserver.requestto be skipped altogether.To address ^this,
#get_multi_yielderhas been updated torescue Timeout::Errorand close all open sockets before re-raising