fix the error "The charnum provided (0) is greater than or equal to the maximum bound (0)" reported by getSubStringLength function#348
Open
DarkMatterV wants to merge 1 commit intobrendangregg:masterfrom
Conversation
…he maximum bound (0)" reported by getSubStringLength function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I use flamegraph.pl to generate svg, when I open it with chrome, I got the error "The charnum provided (0) is greater than or equal to the maximum bound (0)" reported by getSubStringLength function in https://github.com/brendangregg/FlameGraph/blob/master/flamegraph.pl#L946
so, I write a demo to test it, got the error
The getNumberOfChars function gets the length of the string after removing spaces. You can refer to https://chromium.googlesource.com/chromium/blink/+/refs/heads/main/Source/core/svg/SVGTextContentElement.cpp#104