Open
Conversation
The script did call sed in a blocking manner and did also instruct it to create a backup of the original trace file before modifying it in place. This results in a copy of the potentially huge trace file on disk. The sed command is now called in a pipeline allowing the php script to start reading its output before the sed command completes. Also the sed command only parses the original file and does not create a copy. The first argument to the script is now optional, defaulting to stdin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script did call sed in a blocking manner and did also instruct it to create a backup of the original trace file before modifying it in place. This results in a copy of the potentially huge trace file on disk.
The sed command is now called in a pipeline allowing the php script to start reading its output before the sed command completes. Also the sed command only parses the original file and does not create a copy.
The first argument to the script is now optional, defaulting to stdin.
I know that php/xdebug has been updated to include an
xdebug.trace_format=3option that produces the collapsed format for flamegraph.pl directly. But for older versions of php/xdebug which only offer the format 1 it was interesting for me to improve this script.