Merged
Conversation
pyromaniac
commented
Apr 30, 2025
pyromaniac
commented
Apr 30, 2025
pyromaniac
commented
Apr 30, 2025
pyromaniac
commented
Apr 30, 2025
brendon
requested changes
Apr 30, 2025
Owner
brendon
left a comment
brendon
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for separating things out :)
Contributor
Author
|
@brendon why don't you allow running CI without approval? I believe this will make it easier to propose patches shortening the feedback loop. |
Owner
It's just because you're a first time contributor on this gem. It stops abuse like people creating PR's with malicious code that will then be run by Github's servers. |
brendon
requested changes
May 1, 2025
Owner
|
Sorry, one last thing, can you add in a changelog line? :) |
Owner
|
Wonderful. I'll merge and release this now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there.
Firs of all, thanks for initiative, it is awesome, gonna give it a try.
Secondly, at least Healer does not consider nil a a scope value. The example is a tree with parent_id. Some of the parents can be nil and Healer is failing, so here is the fix.