Add optimistic locking and timestamp coverage for positioned list items #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use optimistic locking on tables that also do positioning, the way positioning was done (using
update_all) breaks optimistic locking because it increments the lock_version meaning any already loaded models become stale.So I've migrated to using a lower-level
Arel::UpdateManagerinstead and made sure to also take care of timestamp columns (updated_at etc.) for those who also use caching.Finally we no longer needed
quoted_columnwhich was a bit hacky to begin with, so I removed that method.