Skip to content

Conversation

@Thomas008
Copy link
Contributor

readline(): offset for fseek must be 2
sleep_win(): usleep does not work. used function Sleep() for Windows

@brenhinkeller
Copy link
Owner

I assume the test failures aren't from these changes? If so we can probably merge anyways

@Thomas008
Copy link
Contributor Author

Yes, the code runs in my system. Hopefully you can check it.
The only problem that might occur is to run the function sleep_win() in Linux. Probably it would better to have one sleep-function that decides with Sys.iswindows() which function to take, usleep() or sleep_win(). But usleep() takes mikrosecends as parameter, while I'd prefer seconds (exact to miilliseconds) as in sleep_win().

@brenhinkeller brenhinkeller merged commit 26c0d9f into brenhinkeller:main Apr 7, 2025
2 of 8 checks passed
brenhinkeller referenced this pull request Jun 14, 2025
Add Windows DLL Support and Template-like Variadic Print Functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants