Skip to content

Fix: Failed build #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brenocq merged 3 commits into from
Jan 15, 2025
Merged

Fix: Failed build #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fb40a0d
Chore: Fix ImGuizmo build
brenocq Jan 15, 2025
93e1138
Fix: std::sort not included
brenocq Jan 15, 2025
4fdb065
Chore: Fix curlpp build
brenocq Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/atta/pch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#define ATTA_PRE_COMPILED_HEADER_H

#define _USE_MATH_DEFINES // Windows M_PI fix
#include <algorithm>
#include <any>
#include <array>
#include <bitset>
Expand Down
5 changes: 2 additions & 3 deletions src/extern/solveCurlpp.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,11 @@ if(ATTA_SYSTEM_NAME MATCHES "Linux")
FetchContent_Declare(
curlpp
GIT_REPOSITORY "https://github.com/jpbarrette/curlpp"
GIT_TAG "v0.8.1"
GIT_TAG "d080e301ec71061c46049d23fedfb8106be3153f"
GIT_PROGRESS TRUE
GIT_SHALLOW TRUE
)
atta_log(Info Extern "Fetching curlpp...")
atta_FetchContent_MakeAvailable(curlpp)
atta_FetchContent_MakeAvailable(curlpp)

# Fix INTERFACE_INCLUDE_DIRECTORIES to not include local build
set_property(TARGET curlpp_static PROPERTY INTERFACE_INCLUDE_DIRECTORIES "")
Expand Down
1 change: 0 additions & 1 deletion src/extern/solveImguizmo.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ FetchContent_Declare(
GIT_REPOSITORY "https://github.com/CedricGuillemet/ImGuizmo.git"
GIT_TAG "ba662b1"
GIT_PROGRESS TRUE
GIT_SHALLOW TRUE
)
atta_log(Info Extern "Fetching ImGuizmo...")
FetchContent_MakeAvailable(imguizmo)
Expand Down
2 changes: 1 addition & 1 deletion src/extern/solveImplot.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ set(IMPLOT_SOURCE
add_library(implot STATIC
${IMPLOT_SOURCE}
)
target_include_directories(implot PUBLIC
target_include_directories(implot PUBLIC
$<BUILD_INTERFACE:${FETCHCONTENT_BASE_DIR}/implot-src>
$<INSTALL_INTERFACE:include/${ATTA_VERSION_SAFE}/extern/implot>
)
Expand Down
Loading