Open
Conversation
talmiller2
commented
Sep 3, 2020
talmiller2
commented
- Can now run normal non-local (queue) jobs and local jobs (useful for testing, while using the same scripts).
- Added functions that can check status of jobs and kill them (for both local and non-local runs). Useful for example in envelope scripts that need to wait for jobs to finish to continue sending more jobs or post-process.
- Added tests via unittest for the added functionalities.
- Job names now get to keep their underscores (were previously removed).
brentp
reviewed
Sep 3, 2020
| if bash_strict: | ||
| bash_setup.append("set -eo pipefail -o nounset") | ||
| for k, v in sorted(slurm_kwargs.items()): # sort only for the doctest purpose | ||
| is_long_option = len(k) > 1 |
Owner
There was a problem hiding this comment.
with did you remove the --time arugment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.