Fix communication failures with aws-secretsmanager-jdbc

[gontard]

See commit message.

[lfbayer]

In your case, what is the dataSource classname? Does it contain the name "MySQL", if so the existing contains("Mysql") maybe should just be changed to a case insensitive check.

[gontard]

@CodiumAI-Agent /improve

[QodoAI-Agent]

PR Code Suggestions ✨

Category	Suggestion	Impact
General	Broaden driver class match Broaden the driver class match to support shading or relocated packages by checking for a key substring instead of a full class name. This ensures future compatibility if the AWS driver package changes. src/main/java/com/zaxxer/hikari/pool/PoolBase.java [598] -"com.amazonaws.secretsmanager.sql.AWSSecretsManagerMySQLDriver".equals(driverClassName) +driverClassName != null && driverClassName.contains("AWSSecretsManagerMySQLDriver") Suggestion importance[1-10]: 6 __ Why: Using contains with a null check broadens compatibility for relocated AWS driver classes, improving future-proofing with minimal risk.	Low
	Use case-insensitive matching Perform case-insensitive checks for both dsClassName and jdbcUrl by converting them to lower case before calling contains. This avoids missing matches due to different capitalizations. src/main/java/com/zaxxer/hikari/pool/PoolBase.java [595-596] -(dsClassName != null && dsClassName.contains("Mysql")) || -(jdbcUrl != null && jdbcUrl.contains("mysql")) +(dsClassName != null && dsClassName.toLowerCase().contains("mysql")) || +(jdbcUrl != null && jdbcUrl.toLowerCase().contains("mysql")) Suggestion importance[1-10]: 5 __ Why: Converting to lowercase before contains ensures detection of all capitalization variants in dsClassName and jdbcUrl, enhancing reliability.	Low
	Remove redundant null check Remove the redundant null check on dataSource since the method is only called when dataSource is guaranteed non-null, simplifying the condition. src/main/java/com/zaxxer/hikari/pool/PoolBase.java [597] -(dataSource != null && dataSource.getClass().getName().contains("Mysql")) +dataSource.getClass().getName().contains("Mysql") Suggestion importance[1-10]: 3 __ Why: The private method is only invoked with a non-null dataSource, so omitting the null check simplifies the code without affecting correctness.	Low