Draft
Conversation
Author
|
Changes suggested in the issue #2225 |
brettwooldridge
force-pushed
the
dev
branch
2 times, most recently
from
6d319ab to
7cacd0f
Compare
henriAbel
reviewed
Oct 17, 2024
| metricValueFunction.apply(v) | ||
| Collection<GaugeSnapshot.GaugeDataPointSnapshot> gaugeDataPointSnapshots = new ArrayList<>(); | ||
| poolStatsMap.forEach((k, v) -> gaugeDataPointSnapshots.add( | ||
| new GaugeSnapshot.GaugeDataPointSnapshot(metricValueFunction.apply(v), Labels.of(k), null) |
There was a problem hiding this comment.
Labels.of(k) expects at least 2 arguments.
I think correct would be Labels.of("pool", k)
Author
There was a problem hiding this comment.
makes sense, I pushed the change suggestion
Owner
|
Would this change break existing 1.5 micrometer users? It appears like it would. |
kziel1
force-pushed
the
update-micrometer
branch
from
7af08ed to
1be30e6
Compare
Author
|
Yes, it will break Micrometer because of breaking changes in Prometheus (and simpleclient). |
brettwooldridge
force-pushed
the
dev
branch
2 times, most recently
from
d7a9b2f to
e56fa46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to streamline premetheus versions in the company I work for. Migration guide that could be needed for some use cases: https://github.com/micrometer-metrics/micrometer/wiki/1.13-Migration-Guide