feat: Add fluent-style setters for HikariConfig class#2324
Open
zhangbin90 wants to merge 22 commits intobrettwooldridge:devfrom
Open
feat: Add fluent-style setters for HikariConfig class#2324zhangbin90 wants to merge 22 commits intobrettwooldridge:devfrom
zhangbin90 wants to merge 22 commits intobrettwooldridge:devfrom
Conversation
…n jar back in the day. It was causing .class files to be included in the sources jar. (brettwooldridge#2315)
…on chaining This commit introduces fluent-style setters to the HikariConfig class, allowing for a more readable and concise configuration setup. The new setters enable chaining multiple properties without repeating the variable name, enhancing the overall developer experience. Closes brettwooldridge#2318
brettwooldridge
force-pushed
the
dev
branch
3 times, most recently
from
d7a9b2f to
e56fa46
Compare
Owner
|
There is no way to do this in a backwards compatible way. In Java, the return type is not part of the method signature. Therefore, these two methods cannot coexist: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2318
Summary
This PR introduces fluent-style setters to the HikariConfig class, allowing for a more readable and concise configuration setup. The new setters enable chaining multiple properties without repeating the variable name, enhancing the overall developer experience.
Testing
Ran all unit tests using
./mvn testand verified the log no longer appears.Please review and let me know if any changes are needed.