Clarify keepaliveTime defaults in HikariConfig docs#2372
Open
jbl428 wants to merge 1 commit intobrettwooldridge:devfrom
Open
Clarify keepaliveTime defaults in HikariConfig docs#2372jbl428 wants to merge 1 commit intobrettwooldridge:devfrom
jbl428 wants to merge 1 commit intobrettwooldridge:devfrom
Conversation
|
Hi, it would also be helpful to have a hint in the javadoc what value should be used when a additiontonal connection pool like pgpool is used. Should client keepaliveTime be 0 or smaller than keepalivetime of the pgpool? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update keepalive getter/setter Javadocs to state the true 120 000 ms (2 min) default instead of “0 (disabled)”.