fix: negative numbers cannot be indexed for java arrays#2376
Open
guanchengang wants to merge 1 commit intobrettwooldridge:devfrom
Open
fix: negative numbers cannot be indexed for java arrays#2376guanchengang wants to merge 1 commit intobrettwooldridge:devfrom
guanchengang wants to merge 1 commit intobrettwooldridge:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ConcurrentBag. getStateCounts(), state was directly used as the index of the array.In the original code, there were cases where the state was negative.(
STATE_REMOVEDandSTATE_RESERVED)When an item is in one of these two states,
ArrayIndexOutOfBoundsExceptionwill be thrown.So I modified the values of these two fields and added tests.
If negative values are intentional, we may need to consider modifying the implementation of
getStateCountsto return a Map (if so, please let me know and I would be happy to suggest another PR to fix it).