Open
Conversation
*support properties of boxing types *avoid unnecessary array checks and isAssignableFrom checks *avoid ambiguity when using writeMethod.invoke(Object obj, Object... args)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.support properties of boxing types
Java automatically performs boxing and unboxing for primitive types, so I believe we should adhere to this feature as well.
2.avoid unnecessary array checks and isAssignableFrom checks
Primitive types, along with their array types and String (which is modified by final), cannot have subclasses. Therefore, the original
isArrayandisAssignableFromchecks are meaningless, and we can use==directly (This makes the semantics clearer and can lead to some performance improvements).3.avoid ambiguity when using writeMethod.invoke(Object obj, Object... args)