Open
Conversation
For a complete discussion about changes from v11 to v12, make sure you read carefully the detailed instructions at: https://discordjs.guide/additional-info/changes-in-v12.html
Owner
|
Hey @YannZeRookie, thank you for creating this! I'll take this weekend to review it, and get back to you. Slowly getting back to being more active on GitHub, so bare with me. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had a number of dependencies troubles recently (see #16) and I needed to upgrade to v12 of the Discord.js API anyway, so here is my take at it.
I started by porting the unit tests. After that I made a simple bot from scratch to test the simple examples that you describe in your README. Everything worked great, so I think this is good enough for you to review.
You will note that I slightly updated the required version for botkit to resolve some other failing dependencies. In the future, it would be great to move to version 4, because we still get lots of security warnings with the old 0.7 version. I tried to do it but I gave up because I was not good enough to understand how your code interacts with botkit. I'm sure you will make it in a few minutes compared to the 2 hours I lost trying to do it ;-)
Thanks for your review and corrections, and keep up the great work!
-Yann