Fix refractory handling scope in collect_Events #59
Open
Akshat1000Sharma wants to merge 2 commits intobrian-team:masterfrom
Open
Fix refractory handling scope in collect_Events #59Akshat1000Sharma wants to merge 2 commits intobrian-team:masterfrom
Akshat1000Sharma wants to merge 2 commits intobrian-team:masterfrom
Conversation
Move refractory logic inside the event loop so it is evaluated per event instead of after loop completion. Previously, refractory metadata was attached based on the final loop variable value, causing incorrect behavior when multiple events were present. The update ensures refractory handling is applied only when the current event is 'spike' and avoids reliance on out-of-scope loop variables. This maintains correct behavior with mixed/multiple events and improves code clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move refractory logic inside the event loop so it is evaluated per event instead of after loop completion.
Previously, refractory metadata was attached based on the final loop variable value, causing incorrect behavior when multiple events were present. The update ensures refractory handling is applied only when the current event is 'spike' and avoids reliance on out-of-scope loop variables.
This maintains correct behavior with mixed/multiple events and improves code clarity.
Fixed Issue #57