Add another handler method into JsonServiceExporter with jakarta request and response objects#357
Open
cyb3r4nt wants to merge 1 commit intobriandilley:masterfrom
Conversation
…est and response objects Newer Spring Framework uses jakarta.servlet.http.HttpServletRequest and jakarta.servlet.http.HttpServletResponse objects from the jakarta.* namespace. If JsonRpcServer is registered with @AutoJsonRpcServiceImpl in newer Spring Framework, then request fail due to missing method in a web handler. Newer org.springframework.web.HttpRequestHandler has a signature with jakarta objects, and if JsonServiceExporter has a method with same signature, then it can work with newer Spring MVC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer Spring Framework uses the
jakarta.servlet.http.HttpServletRequestandjakarta.servlet.http.HttpServletResponseobjects from thejakarta.*namespace.If
JsonRpcServeris registered with@AutoJsonRpcServiceImplin newer Spring Framework, then request fail due to missing method in a web handler.Newer
org.springframework.web.HttpRequestHandlerhas a signature withjakartaobjects, and ifJsonServiceExporterhas a method with same signature, then it can work with newer Spring MVC.Support in
JsonRpcServeris already present.