Skip to content

Refactor: Convert to a group of utility functions#7

Merged
briangershon merged 9 commits intomainfrom
simplify
Apr 13, 2025
Merged

Refactor: Convert to a group of utility functions#7
briangershon merged 9 commits intomainfrom
simplify

Conversation

@briangershon
Copy link
Owner

@briangershon briangershon commented Apr 12, 2025

Theme of PR: Simplification

  • Remove higher-level function that built all the posts for all follows. Remove related data structures and types.
  • Instead use generator functions directly in app to offer more flexibility
  • retrieveAuthorFeed() now does the heavy lifting of filtering posts for an author to just one day's worth
  • Refactor tests

See scripts/retrieve-posts.ts for example code for now to use the utility functions.

@briangershon briangershon changed the title Refactor as a small suite of utility functions Refactor: Convert to a small suite of utility functions Apr 12, 2025
@briangershon briangershon changed the title Refactor: Convert to a small suite of utility functions Refactor: Convert to a suite of utility functions Apr 12, 2025
@briangershon briangershon changed the title Refactor: Convert to a suite of utility functions Refactor: Convert to a group of utility functions Apr 12, 2025
Rename test file.
Return proper ValidationResult
Fix invalid post logic
Refactor tests
@briangershon briangershon merged commit dc79f19 into main Apr 13, 2025
1 check passed
@briangershon briangershon deleted the simplify branch April 13, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant