Support BMP images in ICO files #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ICO files containing only BMP images (like ped.ro, evilrabbit.com, mackenziechild.me) would fail because the code only extracted PNG images. This uses decode-ico to properly parse and extract both PNG and BMP images from ICO files, converting BMP data to PNG via sharp. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes favicon loading for sites using BMP-only ICO files (ped.ro, evilrabbit.com, mackenziechild.me, stevensarmi.com). Previously, the code only extracted PNG images from ICO files and would fail when encountering BMP-only files.
Changes
decode-icopackage to properly parse and extract both PNG and BMP imagesextractBestImageFromIcoto convert BMP data to PNG via sharpTesting
Tested with sites containing:
🤖 Generated with Claude Code