Style/PercentLiteralDelimiters

Author: tamird

.rubocop_todo.yml

@@ -78,20 +78,6 @@ Style/GlobalVars:
 Style/NumericLiterals:
   MinDigits: 20
 
-# Offense count: 15
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
-Style/PercentLiteralDelimiters:
-  Exclude:
-    - 'benchmark/active_record.rb'
-    - 'benchmark/active_record_threaded.rb'
-    - 'benchmark/setup_db.rb'
-    - 'ext/mysql2/extconf.rb'
-    - 'spec/mysql2/client_spec.rb'
-    - 'spec/mysql2/result_spec.rb'
-    - 'spec/mysql2/statement_spec.rb'
-    - 'tasks/rspec.rake'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.

benchmark/active_record.rb

@@ -18,7 +18,7 @@ class TestModel < ActiveRecord::Base
 batch_size = 1000
 
 Benchmark.ips do |x|
-  %w(mysql mysql2).each do |adapter|
+  %w[mysql mysql2].each do |adapter|
     TestModel.establish_connection(opts.merge(adapter: adapter))
 
     x.report(adapter) do

benchmark/active_record_threaded.rb

@@ -10,7 +10,7 @@
 opts = { database: 'test', pool: number_of_threads }
 
 Benchmark.ips do |x|
-  %w(mysql mysql2).each do |adapter|
+  %w[mysql mysql2].each do |adapter|
     ActiveRecord::Base.establish_connection(opts.merge(adapter: adapter))
 
     x.report(adapter) do

benchmark/setup_db.rb

@@ -109,8 +109,8 @@ def insert_record(args)
     medium_text_test: twenty5_paragraphs,
     long_blob_test: twenty5_paragraphs,
     long_text_test: twenty5_paragraphs,
-    enum_test: %w(val1 val2).sample,
-    set_test: %w(val1 val2 val1,val2).sample,
+    enum_test: %w[val1 val2].sample,
+    set_test: %w[val1 val2 val1,val2].sample,
   )
   if (n % 100).zero?
     $stdout.putc '.'

ext/mysql2/extconf.rb

@@ -14,7 +14,7 @@ def asplode(lib)
 end
 
 def add_ssl_defines(header)
-  all_modes_found = %w(SSL_MODE_DISABLED SSL_MODE_PREFERRED SSL_MODE_REQUIRED SSL_MODE_VERIFY_CA SSL_MODE_VERIFY_IDENTITY).inject(true) do |m, ssl_mode|
+  all_modes_found = %w[SSL_MODE_DISABLED SSL_MODE_PREFERRED SSL_MODE_REQUIRED SSL_MODE_VERIFY_CA SSL_MODE_VERIFY_IDENTITY].inject(true) do |m, ssl_mode|
     m && have_const(ssl_mode, header)
   end
   $CFLAGS << ' -DFULL_SSL_MODE_SUPPORT' if all_modes_found
@@ -35,7 +35,7 @@ def add_ssl_defines(header)
 
 # borrowed from mysqlplus
 # http://github.com/oldmoe/mysqlplus/blob/master/ext/extconf.rb
-dirs = ENV.fetch('PATH').split(File::PATH_SEPARATOR) + %w(
+dirs = ENV.fetch('PATH').split(File::PATH_SEPARATOR) + %w[
   /opt
   /opt/local
   /opt/local/mysql
@@ -47,7 +47,7 @@ def add_ssl_defines(header)
   /usr/local/mysql-*
   /usr/local/lib/mysql5*
   /usr/local/opt/mysql5*
-).map { |dir| dir << '/bin' }
+].map { |dir| dir << '/bin' }
 
 # For those without HOMEBREW_ROOT in PATH
 dirs << "#{ENV['HOMEBREW_ROOT']}/bin" if ENV['HOMEBREW_ROOT']
@@ -102,7 +102,7 @@ def add_ssl_defines(header)
   asplode 'mysql.h'
 end
 
-%w(errmsg.h).each do |h|
+%w[errmsg.h].each do |h|
   header = [prefix, h].compact.join('/')
   asplode h unless have_header header
 end
@@ -152,7 +152,7 @@ def add_ssl_defines(header)
 case sanitizers
 when true
   # Try them all, turn on whatever we can
-  enabled_sanitizers = %w(address cfi integer memory thread undefined).select do |s|
+  enabled_sanitizers = %w[address cfi integer memory thread undefined].select do |s|
     try_link('int main() {return 0;}',  "-Werror -fsanitize=#{s}")
   end
   abort "-----\nCould not enable any sanitizers!\n-----" if enabled_sanitizers.empty?

spec/mysql2/client_spec.rb

@@ -63,7 +63,7 @@ def connect(*args)
   end
 
   it "should parse flags array" do
-    client = Klient.new flags: %w(FOUND_ROWS -PROTOCOL_41)
+    client = Klient.new flags: %w[FOUND_ROWS -PROTOCOL_41]
     expect(client.connect_args.last[6] & Mysql2::Client::FOUND_ROWS).to eql(Mysql2::Client::FOUND_ROWS)
     expect(client.connect_args.last[6] & Mysql2::Client::PROTOCOL_41).to eql(0)
   end

spec/mysql2/result_spec.rb

@@ -119,7 +119,7 @@
 
     it "should return an array of field names in proper order" do
       result = @client.query "SELECT 'a', 'b', 'c'"
-      expect(result.fields).to eql(%w(a b c))
+      expect(result.fields).to eql(%w[a b c])
     end
   end
 
@@ -428,7 +428,7 @@
       end
 
       context "string encoding for #{type} values" do
-        if %w(VARBINARY TINYBLOB BLOB MEDIUMBLOB LONGBLOB).include?(type)
+        if %w[VARBINARY TINYBLOB BLOB MEDIUMBLOB LONGBLOB].include?(type)
           it "should default to binary if Encoding.default_internal is nil" do
             with_internal_encoding nil do
               result = @client.query("SELECT * FROM mysql2_test ORDER BY id DESC LIMIT 1").first

spec/mysql2/statement_spec.rb

@@ -218,7 +218,7 @@ def stmt_count
 
     it "should be able to retrieve utf8 field names correctly" do
       stmt = @client.prepare 'SELECT * FROM `テーブル`'
-      expect(stmt.fields).to eq(%w(整数 文字列))
+      expect(stmt.fields).to eq(%w[整数 文字列])
       result = stmt.execute
 
       expect(result.to_a).to eq([{ "整数" => 1, "文字列" => "イチ" }, { "整数" => 2, "文字列" => "弐" }, { "整数" => 3, "文字列" => "さん" }])
@@ -342,7 +342,7 @@ def stmt_count
 
     it "should return an array of field names in proper order" do
       stmt = @client.prepare("SELECT 'a', 'b', 'c'")
-      expect(stmt.fields).to eql(%w(a b c))
+      expect(stmt.fields).to eql(%w[a b c])
     end
 
     it "should return nil for statement with no result fields" do
@@ -600,7 +600,7 @@ def stmt_count
       end
 
       context "string encoding for #{type} values" do
-        if %w(VARBINARY TINYBLOB BLOB MEDIUMBLOB LONGBLOB).include?(type)
+        if %w[VARBINARY TINYBLOB BLOB MEDIUMBLOB LONGBLOB].include?(type)
           it "should default to binary if Encoding.default_internal is nil" do
             with_internal_encoding nil do
               result = @client.query("SELECT * FROM mysql2_test ORDER BY id DESC LIMIT 1").first

tasks/rspec.rake

@@ -7,13 +7,13 @@ begin
   desc " Run all examples with Valgrind"
   namespace :spec do
     task :valgrind do
-      VALGRIND_OPTS = %w(
+      VALGRIND_OPTS = %w[
         --num-callers=50
         --error-limit=no
         --partial-loads-ok=yes
         --undef-value-errors=no
         --trace-children=yes
-      ).freeze
+      ].freeze
       cmdline = "valgrind #{VALGRIND_OPTS.join(' ')} bundle exec rake spec"
       puts cmdline
       system cmdline