Style/SignalException

Author: tamird

.rubocop_todo.yml

@@ -78,15 +78,6 @@ Style/GlobalVars:
 Style/NumericLiterals:
   MinDigits: 20
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: only_raise, only_fail, semantic
-Style/SignalException:
-  Exclude:
-    - 'lib/mysql2/client.rb'
-    - 'spec/em/em_spec.rb'
-
 # Offense count: 726
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.

lib/mysql2/client.rb

@@ -21,7 +21,7 @@ def self.default_query_options
     end
 
     def initialize(opts = {})
-      fail Mysql2::Error, "Options parameter must be a Hash" unless opts.is_a? Hash
+      raise Mysql2::Error, "Options parameter must be a Hash" unless opts.is_a? Hash
       opts = Mysql2::Util.key_hash_as_symbols(opts)
       @read_timeout = nil
       @query_options = self.class.default_query_options.dup

spec/em/em_spec.rb

@@ -56,7 +56,7 @@
           defer = client.query "SELECT sleep(0.1) as first_query"
           defer.callback do
             client.close
-            fail 'some error'
+            raise 'some error'
           end
           defer.errback do
             # This _shouldn't_ be run, but it needed to prevent the specs from