Skip to content

Performance improvements when encoding very large hashes with symbol keys #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatmaRex wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −1
Open

Performance improvements when encoding very large hashes with symbol keys #163

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e8a473
Optimize encoding Symbols to JSON
MatmaRex May 14, 2016
9c7d3b0
Optimize encoding String and Symbol keys to JSON
MatmaRex May 14, 2016
558fdf9
Optimize encoding Fixnums to JSON
MatmaRex May 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ext/yajl/yajl_ext.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ void yajl_encode_part(void * wrapper, VALUE obj, VALUE io) {
keys = rb_funcall(obj, intern_keys, 0);
for(idx=0; idx<RARRAY_LEN(keys); idx++) {
entry = rb_ary_entry(keys, idx);
keyStr = rb_funcall(entry, intern_to_s, 0); /* key must be a string */
/* key must be encoded as a string */
if(RB_TYPE_P(entry, T_STRING) || RB_TYPE_P(entry, T_SYMBOL)) {
keyStr = entry;
} else {
keyStr = rb_funcall(entry, intern_to_s, 0);
}
/* the key */
yajl_encode_part(w, keyStr, io);
/* the value */
Expand All @@ -194,6 +199,11 @@ void yajl_encode_part(void * wrapper, VALUE obj, VALUE io) {
CHECK_STATUS(yajl_gen_bool(w->encoder, 0));
break;
case T_FIXNUM:
str = rb_fix2str(obj, 10);
cptr = RSTRING_PTR(str);
len = RSTRING_LEN(str);
CHECK_STATUS(yajl_gen_number(w->encoder, cptr, len));
break;
case T_FLOAT:
case T_BIGNUM:
str = rb_funcall(obj, intern_to_s, 0);
Expand All @@ -209,6 +219,12 @@ void yajl_encode_part(void * wrapper, VALUE obj, VALUE io) {
len = RSTRING_LEN(obj);
CHECK_STATUS(yajl_gen_string(w->encoder, (const unsigned char *)cptr, len));
break;
case T_SYMBOL:
str = rb_id2str(SYM2ID(obj));
cptr = RSTRING_PTR(str);
len = RSTRING_LEN(str);
CHECK_STATUS(yajl_gen_string(w->encoder, (const unsigned char *)cptr, len));
break;
default:
if (rb_respond_to(obj, intern_to_json)) {
str = rb_funcall(obj, intern_to_json, 0);
Expand Down