Listen to Global Transform Change notifications#76
Open
jasonwinterpixel wants to merge 1 commit intobriansemrau:3.xfrom
Open
Listen to Global Transform Change notifications#76jasonwinterpixel wants to merge 1 commit intobriansemrau:3.xfrom
jasonwinterpixel wants to merge 1 commit intobriansemrau:3.xfrom
Conversation
jasonwinterpixel
force-pushed
the
use_notify_transform
branch
from
fddd48b to
70b5f67
Compare
jasonwinterpixel
force-pushed
the
use_notify_transform
branch
from
70b5f67 to
f6ca61f
Compare
|
|
||
| Box2DPhysicsBody::Box2DPhysicsBody() { | ||
| set_physics_process_internal(true); | ||
| set_notify_local_transform(true); |
Author
There was a problem hiding this comment.
This is not needed because Box2DCollisionObject's constructor does it.
|
You can merge this straight into Side-note, I could have sworn there were situations where I wrote: set_notify_local_transform(false);
// do something
set_notify_local_transform(true);But I don't see them now. Curious. |
Author
|
You did it for kinematic bodies using set_notify_transform.
…On Tue, Oct 18, 2022, 10:14 p.m. Brian Semrau ***@***.***> wrote:
You can merge this straight into winterpixelgames:winterpixel-main. LGTM
Side-note, I could have sworn there were situations where I wrote:
set_notify_local_transform(false);// do somethingset_notify_local_transform(true);
But I don't see them now. *Curious.*
—
Reply to this email directly, view it on GitHub
<#76 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS2HDAON3YFD2GYRVSGTI5TWD5YTHANCNFSM6AAAAAARIQRICY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use set_notify_transform() instead of set_notify_local_transform().