Fix training_data_separate and evaluation_data_separate type mismatch #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally Co-authored-by: realmarcin <4625870+realmarcin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on extending LinkML schema for model card coverage
Fix training_data_separate and evaluation_data_separate type mismatch
Nov 23, 2025
- Updated Python version from 3.9 to 3.12 in test workflow - Changed Poetry installation from snok action to pip (firewall workaround) - Added --no-root flag to all poetry install commands - Fixed pyproject.toml: poetry.dev-dependencies → poetry.group.dev.dependencies - Added packages configuration to pyproject.toml - Updated include paths to match actual structure 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PyYAML 6.0 doesn't have pre-built wheels for Python 3.12 and fails to build from source with Cython errors. Updated to PyYAML 6.0.3 which includes Python 3.12 wheels. Fixes: AttributeError: cython_sources in PEP517 build 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
greenlet 1.1.2 doesn't have Python 3.12 wheels and fails to build from source due to incompatibility with Python 3.12's internal C API changes. Updated to greenlet 3.2.4 which includes Python 3.12 wheels. Fixes: Build errors with CFrame, exc_type, recursion_depth in Python 3.12 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global slot definitions for
training_data_separateandevaluation_data_separatewere incorrectly typed asmultivalued: true, range: dataSet, conflicting with their boolean usage in TrainingProcedure and EvaluationProcedure classes.Changes
training_data_separateglobal slot from multivalued dataSet to booleanevaluation_data_separateglobal slot from multivalued dataSet to booleanBefore/After
The class-level definitions already used
range: boolean, so this aligns the global definitions with actual usage.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.