Skip to content

fix: ensures only one thread can execute transient settings #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lirshindalman wants to merge 2 commits into from
Closed

fix: ensures only one thread can execute transient settings #291

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a628119
.
Feb 26, 2026
c559857
.
Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions detect_secrets/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,32 @@ def default_settings() -> Generator['Settings', None, None]:

@contextmanager
def transient_settings(config: Dict[str, Any]) -> Generator['Settings', None, None]:
"""Allows the customizability of non-global settings per invocation."""
original_settings = get_settings().json()
"""Allows the customizability of non-global settings per invocation.

cache_bust()
Thread-safe version. Preserves the get_settings() singleton
in the LRU cache to prevent race conditions when multiple threads access
detect-secrets state concurrently (e.g., IAC + SECRETS scanners running
in parallel via ThreadPoolExecutor on macOS).
"""
settings = get_settings()
original_plugins = deepcopy(dict(settings.plugins))
original_filters = deepcopy(dict(settings.filters))

# Clear dependent caches — NOT get_settings()
get_plugins.cache_clear()
get_filters.cache_clear()
from .core.plugins.util import get_mapping_from_secret_type_to_class
get_mapping_from_secret_type_to_class.cache_clear()

settings.clear()
try:
yield configure_settings_from_baseline(config)
finally:
cache_bust()
configure_settings_from_baseline(original_settings)
get_plugins.cache_clear()
get_filters.cache_clear()
get_mapping_from_secret_type_to_class.cache_clear()
settings.plugins = original_plugins
settings.filters = original_filters


def cache_bust() -> None:
Expand Down
Loading