fix(azure_storage_key): broaden azure storage account key pattern#292
Merged
lirshindalman merged 1 commit intomasterfrom Mar 17, 2026
Merged
Conversation
yuvalmich
changed the title
lirshindalman
approved these changes
Mar 17, 2026
eliviatar
reviewed
Mar 17, 2026
… variable names
- Changed account_key context pattern from literal 'AccountKey' to regex
'account[_]?k(?:ey)?\b' (case-insensitive) to match variable names like
STORAGE_ACCOUNT_K, STORAGE_ACCOUNT_KEY, account_key, AccountKey, etc.
- Narrowed denylist base64 range from {86,1000} to {86,88} to match actual
Azure Storage key length (64 bytes = 86 base64 chars + '==')
- Updated early-exit optimization to use regex-based check instead of
literal string match
- Added unit test for STORAGE_ACCOUNT_K=<secret> pattern
yuvalmich
force-pushed
the
fix/azure-storage-key-flexible-account-pattern
branch
from
efb5bdc to
d148912
Compare
eliviatar
approved these changes
Mar 17, 2026
omriyoffe-panw
approved these changes
Mar 17, 2026
lirshindalman
deleted the
fix/azure-storage-key-flexible-account-pattern
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?