Terraform/Azure/networking.tf adding an NSG rule resource tied to a n… #524
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform/Azure/networking.tf adding NSG rule resources tied to a new NSG called 'bad_sg2'
Currently the Azure networking resource only include a standalone NSG resource
azurerm_network_security_group(renamedbad_sg1.tf) with NSG rules defined in-line. (https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/network_security_rule)This pull request proposed to add another case with a new NSG resource (
bad_sg2.tf) tied to a couple of separate NSG rule resourceazurerm_network_security_rulecalledbad_rule1.tffor SSH andbad_rule2.tffor RDP.(https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/network_security_rule)
Also included a minor correction to the
storage.tffile which actually require thestorage_account_id.