fix: Handle non-string Playwright snapshots without crashing#89
Draft
fix: Handle non-string Playwright snapshots without crashing#89
Conversation
Collaborator
meirk-brd
commented
Dec 2, 2025
- Ensure filter_snapshot returns the raw _snapshotForAI output when it isn’t text, avoiding TypeErrors.
- Simplify parse_playwright_snapshot by removing redundant type check now that the guard/fallback lives in filter_snapshot.
- Keeps ARIA parsing intact for string snapshots while letting DOM snapshot logic proceed on unexpected types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.