Skip to content

Update platform requirements to match RadiantKit minimums (#139) #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leogdion wants to merge 1 commit into from
Closed

Update platform requirements to match RadiantKit minimums (#139) #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
- Modern Swift features: noncopyable generics, variadic generics

**Requirements:**
- **macOS:** Xcode 16.0+, Swift 6.0+, macOS 14+ deployment target
- **macOS:** Xcode 16.0+, Swift 6.0+, macOS 15+ deployment target
- **Linux:** Ubuntu 20.04+, Swift 6.0+

## Common Development Commands
Expand Down
12 changes: 6 additions & 6 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3227,12 +3227,12 @@ import PackageDescription

struct WWDC2023: PlatformSet {
var body: any SupportedPlatforms {
SupportedPlatform.macOS(.v12)
SupportedPlatform.iOS(.v15)
SupportedPlatform.watchOS(.v8)
SupportedPlatform.tvOS(.v15)
SupportedPlatform.visionOS(.v1)
SupportedPlatform.macCatalyst(.v15)
SupportedPlatform.macOS(.v15)
SupportedPlatform.iOS(.v18)
SupportedPlatform.watchOS(.v11)
SupportedPlatform.tvOS(.v18)
SupportedPlatform.visionOS(.v2)
SupportedPlatform.macCatalyst(.v18)
}
}
//
Expand Down
12 changes: 6 additions & 6 deletions Package/Sources/Platforms/WWDC2023.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ import PackageDescription

struct WWDC2023: PlatformSet {
var body: any SupportedPlatforms {
SupportedPlatform.macOS(.v12)
SupportedPlatform.iOS(.v15)
SupportedPlatform.watchOS(.v8)
SupportedPlatform.tvOS(.v15)
SupportedPlatform.visionOS(.v1)
SupportedPlatform.macCatalyst(.v15)
SupportedPlatform.macOS(.v15)
SupportedPlatform.iOS(.v18)
SupportedPlatform.watchOS(.v11)
SupportedPlatform.tvOS(.v18)
SupportedPlatform.visionOS(.v2)
SupportedPlatform.macCatalyst(.v18)
Comment on lines +34 to +39
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Step 1: Check if RadiantKit is a dependency in the current Package.swift
echo "=== Searching for RadiantKit dependency in current Package.swift ==="
rg -n "RadiantKit" Package.swift | head -20

Repository: brightdigit/BushelKit

Length of output: 447

🏁 Script executed:

#!/bin/bash
# Clone RadiantKit and check its Package.swift platform requirements
TEMP_DIR=$(mktemp -d)
trap "rm -rf $TEMP_DIR" EXIT

echo "=== Cloning RadiantKit repository ==="
git clone --depth 1 https://github.com/brightdigit/RadiantKit.git "$TEMP_DIR/RadiantKit" 2>&1 | grep -E "Cloning|fatal"

if [ -f "$TEMP_DIR/RadiantKit/Package.swift" ]; then
  echo ""
  echo "=== RadiantKit Platform Requirements ==="
  rg -n "\.macOS|\.iOS|\.watchOS|\.tvOS|\.visionOS|\.macCatalyst" "$TEMP_DIR/RadiantKit/Package.swift" -B 2 -A 2
else
  echo "ERROR: Could not find RadiantKit Package.swift"
  exit 1
fi

Repository: brightdigit/BushelKit

Length of output: 392

Platform versions in WWDC2023.swift exceed RadiantKit's actual requirements.

RadiantKit (1.0.0-beta.4) specifies: macOS .v12, iOS .v15, watchOS .v8, tvOS .v15, visionOS .v1, and macCatalyst .v15. However, WWDC2023.swift defines significantly higher versions: macOS .v15, iOS .v18, watchOS .v11, tvOS .v18, visionOS .v2, and macCatalyst .v18. These version jumps are not justified by the RadiantKit dependency and unnecessarily increase the minimum deployment targets beyond what's required.

Verify the rationale for these version bumps. If they are not driven by RadiantKit requirements, consider aligning them to the actual dependency minimums or document the reason for the higher targets.

🤖 Prompt for AI Agents 
In @Package/Sources/Platforms/WWDC2023.swift around lines 34 - 39, The
WWDC2023.swift SupportedPlatform declarations (e.g.,
SupportedPlatform.macOS(.v15), iOS(.v18), watchOS(.v11), tvOS(.v18),
visionOS(.v2), macCatalyst(.v18)) raise deployment targets above RadiantKit's
stated minima; adjust these values to match RadiantKit 1.0.0-beta.4 minimums
(macOS .v12, iOS .v15, watchOS .v8, tvOS .v15, visionOS .v1, macCatalyst .v15)
unless there is an explicit, documented reason for higher targets—if a higher
target is required, add a short comment in WWDC2023.swift explaining the
rationale and which API or dependency enforces the increase.

}
}
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ This is an open-source component for [Bushel, a macOS virtual machine app](https

- Xcode 16.0 or later
- Swift 6.0 or later
- iOS 17 / watchOS 10.0 / tvOS 17 / macOS 14 or later deployment targets
- iOS 18 / watchOS 11 / tvOS 18 / macOS 15 or later deployment targets

**Linux**

Expand Down
Loading