Skip to content

Conversation

adalessandro
Copy link

Following MR OSSystems#920
Please review and rebase your branch with this one, so the upstream MR gets updated for final submission.

I've kept you as the commit author, then added your signed-off-by and mine.

OldManYellsAtCloud and others added 6 commits September 23, 2025 08:17
This also includes some refactoring of the recipe - instead of using crates
downloaded by the recipe, use the crates vendored in the Firefox tarball.
It looks that it builds successfully with that now.

Signed-off-by: Gyorgy Sarvari <user.name>
This also includes a refactoring of the recipe: instead of using crates
downloaded by the recipe, use crates included in the Firefox tarball.
It seems that it builds fine now using them.

Signed-off-by: Gyorgy Sarvari <user.name>
Initially, when the crates include was added, Firefox's vendored crates
were not enough to build Firefox, it required downloading a number of
other crates to be able to compile without failure.

Now however it looks that the tarball contains all required crates, so
use it instead of vendoring them from the recipe.

Signed-off-by: Gyorgy Sarvari <[email protected]>
https://www.firefox.com/en-US/firefox/143.0.3/releasenotes/
https://www.firefox.com/en-US/firefox/143.0.4/releasenotes/

Also remove an obsolete custom function from the recipe which
isn't used anymore (used to suppress cargo_common bbclass
from adding the extra git repositories as cargo dependency
patches)

Signed-off-by: Gyorgy Sarvari <[email protected]>
Chromium 138+ uses its bundled libc++ and compiler-rt. To ensure the build
system uses these and does not fall back to system-provided runtime
libraries, explicitly pass the target triple and disable system stdlib++.

This avoids linker errors caused by missing crtbeginS.o, crtendS.o, and
libgcc when using Clang with a minimal sysroot.

Release Notes:
    https://chromereleases.googleblog.com/2025/07/stable-channel-update-for-desktop_15.html

Build and patch changes:
------------------------

Added patches:
  * 0011-fix-check_version-Only-compare-node.js-major-version.patch

Updated patches:
  * 0009-Adjust-the-Rust-build-to-our-needs.patch

Removed patches:
  * 0011-Revert-Allow-and-use-std-hardware_destructive_interf.patch
  * 0012-Revert-Set-Rust-symbol-visibility-to-hidden-when-C-s.patch
  * 0013-pdfium-Fix-missing-PDFiumAPIStringBufferAdapter-temp.patch
  * 0014-Revert-Remove-libavif-based-AVIF-decoder.patch
  * 0015-Revert-Remove-third_party-libavif.patch
  * 0016-Disable-crabbyavif-to-fix-build-errors.patch
  * 0017-rust-Use-adler-instead-of-adler2.patch
  * 0018-third_party-node-update_node_binaries-Update-nodejs-.patch
  * 0020-rust-filter-out-arm-specific-flags-from-rust-compile.patch

License changes:
----------------

Added licenses:
  * third_party/compiler-rt/src/LICENSE.TXT
  * third_party/libtess2/LICENSE
  * third_party/llvm-libc/src/LICENSE.TXT
  * third_party/net/third_party/mozilla_security_manager/LICENSE

Removed licenses:
  * third_party/accessibility-audit/LICENSE
  * third_party/io_grpc_grpc_api/LICENSE
  * third_party/libavifinfo/LICENSE

Updated licenses:
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth/LICENSE -> third_party/android_deps/autorolled/committed/libs/com_google_android_gms_play_services_auth/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth_api_phone/LICENSE -> third_party/android_deps/autorolled/committed/libs/com_google_android_gms_play_services_auth_api_phone/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth_base/LICENSE -> third_party/android_deps/autorolled/committed/libs/com_google_android_gms_play_services_auth_base/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_auth_blockstore/LICENSE -> third_party/android_deps/autorolled/committed/libs/com_google_android_gms_play_services_auth_blockstore/LICENSE
  * third_party/android_deps/libs/com_google_android_gms_play_services_fido/LICENSE -> third_party/android_deps/autorolled/committed/libs/com_google_android_gms_play_services_fido/LICENSE
  * third_party/android_deps/libs/com_google_android_libraries_identity_googleid_googleid/LICENSE -> third_party/android_deps/autorolled/committed/libs/com_google_android_libraries_identity_googleid_googleid/LICENSE
  * third_party/expat/src/expat/COPYING
  * third_party/libjpeg_turbo/LICENSE

Test-built:
-----------

* chromium-ozone-wayland
  * MACHINE=qemux86-64, qemuarm, qemuarm64

* chromium-x11
  * MACHINE=qemux86-64, qemuarm, qemuarm64

Test dependencies:
------------------

* URI: git://git.yoctoproject.org/poky
  - branch: master
  - revision: 243d54fd466f5f852cc0fdcce57997918ce35f32

* URI: git://git.openembedded.org/meta-openembedded
  - layers: meta-oe
  - branch: master
  - revision: a8dfd10600035a799abae03178fc7054582ea43d

* URI: git://github.com/kraj/meta-clang
  - branch: master
  - revision: 7a2f83360920b10214e2659e17a4b9cba2d0435b

Signed-off-by: Caner Altinbasak <[email protected]>
Signed-off-by: Ariel D'Alessandro <[email protected]>
@caneraltinbasak
Copy link

Can you please resolve the conflicts?

@adalessandro
Copy link
Author

Can you please resolve the conflicts?

This is a request to rebase / force push your branch, rather than merging it. So this goes directly to the upstream MR OSSystems#920

@caneraltinbasak
Copy link

Please review and rebase your branch with this one, so the upstream MR gets updated for final submission.

Ah I see, didn't see your previous message. I'll sort that out manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants