Skip to content

Conversation

@jameskerr
Copy link
Contributor

Fixes #260

This let's us utilize the "escape" key to cancel a drag. It also cancels a drag if you drop it outside of the tree. Here's a video showing this at work.

escape-cancel.mp4

@jameskerr jameskerr merged commit d50c9ab into main Feb 6, 2025
1 check passed
@jameskerr jameskerr deleted the escape branch February 6, 2025 20:03
@SpencerHC
Copy link

SpencerHC commented Feb 26, 2025

Hey, thanks for all the work on this!

I'm now having trouble with reordering an item below the bottom item. The hit area is much smaller than it was previously and doesn't trigger my custom handleMove anymore. Is there a fix for this? Maybe with ignoreDropsOutside? Thanks again!

@yalogica
Copy link

yalogica commented Mar 4, 2025

Hey, thanks for all the work on this!

I'm now having trouble with reordering an item below the bottom item. The hit area is much smaller than it was previously and doesn't trigger my custom handleMove anymore. Is there a fix for this? Maybe with ignoreDropsOutside? Thanks again!

I have a similar problem, now I have to drop the dragged element on the tree row, if I don't and I drop outside the row but inside the tree component, then onMove doesn't call.
It's fine with [email protected], but not with versions higher than that.

outer drop

@jameskerr
Copy link
Contributor Author

Thanks for reporting. Let's get that fixed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't cancel dragging after it started

4 participants