Skip to content

vam: Support NullScan #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattnibs merged 2 commits into from
Feb 3, 2025
Merged

vam: Support NullScan #5613

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa52ced
vam: Support NullScan
mattnibs Jan 31, 2025
60c8b1c
Update compiler/kernel/vop.go
mattnibs Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/kernel/vop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ func (b *Builder) compileVamLeaf(o dag.Op, parent vector.Puller) (vector.Puller,
return vamop.NewFilter(b.zctx(), parent, e), nil
case *dag.Head:
return vamop.NewHead(parent, o.Count), nil
case *dag.NullScan:
return vector.NewPuller(vector.NewConst(super.Null, 1, nil)), nil
case *dag.Output:
b.channels[o.Name] = append(b.channels[o.Name], vam.NewMaterializer(parent))
return parent, nil
Expand Down
17 changes: 17 additions & 0 deletions vector/any.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,20 @@ type Promotable interface {
type Puller interface {
Pull(done bool) (Any, error)
}

type puller struct {
vecs []Any
}

func NewPuller(vecs ...Any) Puller {
return &puller{vecs}
}

func (p *puller) Pull(_ bool) (Any, error) {
if len(p.vecs) == 0 {
return nil, nil
}
vec := p.vecs[0]
p.vecs = p.vecs[1:]
return vec, nil
}