Conversation
philrz
changed the title
nwt
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr
This brings back the consistent use of
|instead of|>in docs, tests, and a few other select places. There's a handful of places where the|>is still used, such as where we explain to users that both are supported, as well as tests that ensure queries work with both symbols.I suggest that reviewers look through those remaining
|>appearances in a local checkout of this branch to confirm you agree with keeping them.Details
We briefly went all the way over to using exclusively
|>in #5427 but then brought back|in #5436. When @mccanne recently wrote the Pipeline Symbol doc he explained that we prefer|and expect most users would too, so it seems only fitting our docs and other materials would reflect this in a consistent way.