Manage the goimports and pigeon commands as Go tool dependencies#5763
Merged
Manage the goimports and pigeon commands as Go tool dependencies#5763
Conversation
This moves the goimports and pigeon command version specifications from compiler/parser/Makefile to go.mod, moves the invocation of those commands to Makefile, and removes compiler/parser/Makefile. To force rebuilding of the PEG parser, run "make -B peg" instead of "make -C compiler/parser". (The latter no longer works because compiler/parser/Makefile no longer exists.)
nwt
added a commit
that referenced
this pull request
Sep 3, 2025
That directory hasn't been used since #5763.
nwt
added a commit
that referenced
this pull request
Sep 4, 2025
That directory hasn't been used since #5763.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the goimports and pigeon command version specifications from compiler/parser/Makefile to go.mod, moves the invocation of those commands to Makefile, and removes compiler/parser/Makefile.
To force rebuilding of the PEG parser, run "make -B peg" instead of "make -C compiler/parser". (The latter no longer works because compiler/parser/Makefile no longer exists.)