Conversation
This commit moves the projection data structure used by vcache into the generic field package so it can be shared in more places without creating import cycles. This is needed by an upcoming PR that will add projection pushdown to the CSUP metadata filter, which is needed by a subsequent PR that will make CSUP more efficient by allowing lazy loading of types.
nwt
approved these changes
Apr 6, 2025
pkg/field/projection.go
Outdated
| // A path is an array of string or Forks | ||
| type Path []any //XXX clean this up later | ||
| type Fork []Path | ||
| // A Projection is an array of string or Forks |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| // A Projection is an array of string or Forks | |
| // A Projection is an slice of string or Forks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the projection data structure used by vcache into the generic field package so it can be shared in more places without creating import cycles.
This is needed by an upcoming PR that will add projection pushdown to the CSUP metadata filter, which is needed by a subsequent PR that will make CSUP more efficient by allowing lazy loading of types.