Conversation
This commit unifies the pushdown logic for filtering, BSUP filtering, CSUP metadata filtering, and projection into a single interface called zbuf.Pushdown replacing zbuf.Filter. We also added projections to the data filters and arranged for the CSUP reader to project only the needed metadata values according to this projection. These changes are needed to an upcoming PR that will improve the efficiency of CSUP by doing lazy type loading.
nwt
reviewed
Apr 7, 2025
compiler/kernel/op.go
Outdated
|
|
||
| func (b *Builder) PushdownOf(e dag.Expr) *Filter { | ||
| if e == nil { | ||
| func (b *Builder) NewPushdown(e dag.Expr, projection []field.Path) *pushdown { |
Member
There was a problem hiding this comment.
But: Return a zbuf.Pushdown here since it's a little opaque for a public method to return an unexported type.
Collaborator
Author
There was a problem hiding this comment.
This is only needed by a test. We can change the test and not export NewPushdown
nwt
reviewed
Apr 7, 2025
nwt
reviewed
Apr 7, 2025
nwt
reviewed
Apr 7, 2025
nwt
reviewed
Apr 7, 2025
nwt
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit unifies the pushdown logic for filtering, BSUP filtering, CSUP metadata filtering, and projection into a single interface called zbuf.Pushdown replacing zbuf.Filter. We also added projections to the data filters and arranged for the CSUP reader to project only the needed metadata values according to this projection.
These changes are needed to an upcoming PR that will improve the efficiency of CSUP by doing lazy type loading.