runtime/vam: return error on cast of invalid UTF-8 bytes to string #6273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sequential runtime returns a structured error when a bytes value containing invalid UTF-8 is cast to a string. Do the same in the vector runtime. The change in runtime/vam/expr/cast.castToString implements the new behavior. The remaining changes just add a msgSuffix parameter to errCastFailed so castToString can produce the same error message as the sequential runtime. There are some possible optimizations here but they can wait until castToString appears in CPU profiles.
mccanne
approved these changes
Oct 2, 2025
mattnibs
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sequential runtime returns a structured error when a bytes value containing invalid UTF-8 is cast to a string. Do the same in the vector runtime.
The change in runtime/vam/expr/cast.castToString implements the new behavior. The remaining changes just add a msgSuffix parameter to errCastFailed so castToString can produce the same error message as the sequential runtime.
There are some possible optimizations here but they can wait until castToString appears in CPU profiles.
The test coverage added to runtime/ztests/expr/cast/string.yaml
duplicates runtime/sam/expr/ztests/cast-bytes-string-err.yaml, so remove
the latter file.