Closed
Conversation
Contributor
Author
|
In a group discussion there was consensus that this should be a nightly job and should run in the Homebrew Tap repo. I'll open a new PR over there that takes that approach. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changing
This builds on #6271 by creating artifacts as each PR merges and updating a Homebrew Cask to make those artifacts available on a public S3 bucket.
Why
main, which should get us better user testing in this prerelease phaseDetails
Consensus has been that we don't want any artifacts on the super Releases page on GitHub until we're ready to tag a GA release. The approach here gets around that putting the artifacts on a public S3 bucket instead and having the Homebrew Cask point at those URLs.
Part of the goal here is to get prerelease users off the Formula and onto the Cask before GA. Based on my research there's no way to silently force that transition, so when this merges, my next planned step will be to replace the old
super.rbHomebrew Formula with one that installs a shim that will advise users of the minimal steps to switch over to the Cask. At that point they'll start getting updatedsuperbinaries as part of every generalbrew update/brew upgrade. I'd plan to remove thatsuper.dbFormula entirely right before we tag the GA release.I've tested this extensively in a personal super fork and personal Homebrew tap so if you want to see proof it works run
brew install philrz/tap/superon a scratch macOS system with Homebrew installed.