Conversation
Casting of complex types is implemented in runtime/sam/expr/shaper.go. Replace it with a new implementation in runtime/sam/expr/function/cast.go with these differences: * Preserves target type field order when casting records * Able to cast maps * More maintainable
mattnibs
approved these changes
Oct 3, 2025
mccanne
reviewed
Oct 4, 2025
runtime/sam/expr/function/cast.go
Outdated
| } | ||
| return c.cast(from, typ) | ||
| } | ||
| return c.sctx.WrapError("cannot cast to "+sup.FormatValue(to), from) |
Collaborator
There was a problem hiding this comment.
Maybe an error here about the second argument when the second arg isn't a type or string, e.g., instead of
; super -c "cast(1,2)"
error({message:"cannot cast to 2",on:1})
maybe
error({message:"cast target must be a type or name of type",on:2})
mccanne
approved these changes
Oct 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting of complex types is implemented in runtime/sam/expr/shaper.go.
Replace it with a new implementation in
runtime/sam/expr/function/cast.go with these differences:
Always generates a structured error when casting fails
Preserves target type field order when casting records
Able to cast maps
More maintainable
Fixes #2894
Fixes #4315
Closes #5168
Closes #6023