remove crop(), fill(), fit(), order(), and shape()#6286
Merged
Conversation
cast() is generally sufficient though we may add a variant that doesn't add missing fields with a null value when casting records. runtime/sam/expr.ConstShaper has to stick around because it's used in runtime/sam/op/fuse. We can remove it in favor of runtime/sam/expr/function.cast after we enhance that latter to handle union-typed record fields in the target type.
This was referenced Oct 7, 2025
mattnibs
approved these changes
Oct 7, 2025
Collaborator
mattnibs
left a comment
mattnibs
left a comment
There was a problem hiding this comment.
Should we remove the docs as well or just keep them?
Member
Author
|
@mattnibs: I don't think there are any right now. I get no output from this: git grep '(crop|fill|fit|order|shape)\(' -- book/src |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast() is generally sufficient though we may add a variant that doesn't add missing fields with a null value when casting records.
runtime/sam/expr.ConstShaper has to stick around because it's used in runtime/sam/op/fuse. We can remove it in favor of runtime/sam/expr/function.cast after we enhance that latter to handle union-typed record fields in the target type.