unify AST naming #6288
Merged
unify AST naming #6288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit unifies the naming patterns of the AST to be consistent with the DAG and the semantic tree. Ops have suffixes "Op" and ast.Exprs have suffix "Expr". We removed the Kind field from structs that aren't part of sum types. We also separate ast.ID into ID and IDExpr to differentiate the use of ID in an expression versus identifiers in other non-expression entities. There are further improvements that can be made but this is a big step in the right direction.
nwt
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit unifies the naming patterns of the AST to be consistent with the DAG and the semantic tree. Ops have suffixes "Op" and ast.Exprs have suffix "Expr".
We removed the Kind field from structs that aren't part of sum types. We also separate ast.ID into ID and IDExpr to differentiate the use of ID in an expression versus identifiers in other non-expression entities.
There are further improvements that can be made but this is a big step in the right direction.