support column-id resolution in SQL pipe subqueries #6303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a pipe schema concept to the semantic pass so that column references can be properly resolved for pipe subqueries embedded as SQL table expressions. It calls the type checker to compute the super.Type of the pipe subquery and uses that type to infer the available columns for SQL expressions. This logic will need to be extended when we add support for correlated subqueries, likely requiring type tracking to be more tightly integrated with the translator pass (e.g., tracking the type all the way from the input to the query instead of locally analyzing the pipe subquery).
nwt
approved these changes
Oct 14, 2025
compiler/semantic/checker.go
Outdated
Comment on lines
447
to
448
| // If we're spreading an unknown type into this record, we don't | ||
| // the result at all. Return unknown for the whole thing. |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| // If we're spreading an unknown type into this record, we don't | |
| // the result at all. Return unknown for the whole thing. | |
| // If we're spreading an unknown type into this record, we don't | |
| // know the result at all. Return unknown for the whole thing. |
compiler/semantic/checker.go
Outdated
Comment on lines
892
to
904
| func recordOf(typ super.Type) *super.TypeRecord { | ||
| switch typ := super.TypeUnder(typ).(type) { | ||
| case *super.TypeRecord: | ||
| return typ | ||
| case *super.TypeUnion: | ||
| for _, typ := range typ.Types { | ||
| if typ := recordOf(typ); typ != nil { | ||
| return typ | ||
| } | ||
| } | ||
| } | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
Nit: Put this in schema.go after newPipeSchema since that's where it's called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a pipe schema concept to the semantic pass so that column references can be properly resolved for pipe subqueries embedded as SQL table expressions. It calls the type checker to compute the super.Type of the pipe subquery and uses that type to infer the available columns for SQL expressions.
This logic will need to be extended when we add support for correlated subqueries, likely requiring type tracking to be more tightly integrated with the translator pass (e.g., tracking the type all the way from the input to the query instead of locally analyzing the pipe subquery).