add support for re-entering subqueries in recursive functions #6325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where a conditional expression was causing a fatal error if either branch of the conditional had a type error. The fix is to report an error only when both branches have errors.
This commit addresses an unfinished aspect of subqueries when they are invoked from resursive functions. Previously, the subquery would incorrectly block as Eval() is called concurrently violating our invariant. The fix is to keep a stack of non-shared subquery instances that can be used when recursion is detected. This inovlves calling the rungen builder from the runtime whenever we need a new instance, which turned out to be surprisingly easy to implement.
nwt
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses an unfinished aspect of subqueries when they are invoked from resursive functions. Previously, the subquery would incorrectly block as Eval() is called concurrently violating our invariant.
The fix is to keep a stack of non-shared subquery instances that can be used when recursion is detected. This involves calling the rungen builder from the runtime whenever we need a new instance, which turned out to be surprisingly easy to implement.
Fixes #6211