pkg/storage: expose os.Stdin's Close and ReadAt methods #6338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StdinEngine.Get wraps os.Stderr with io.NopCloser and notSupportedReaderAt to hide its Close and ReadAt methods. This doesn't appear to be necessary, and exposing ReadAt enables reading CSUP and Parquet files from standard input.
mattnibs
approved these changes
Nov 4, 2025
nwt
changed the title
nwt
added a commit
that referenced
this pull request
Nov 4, 2025
Exposing os.Stdin.Close in #6338 was a mistake because opening stdio:stdin with pkg/storage, closing it, and opening it again now returns a reader on which reads always fail with "read /dev/stdin: file already closed". Hide os.Stdin.Close again to prevent that error.
nwt
added a commit
that referenced
this pull request
Nov 4, 2025
Exposing os.Stdin.Close in #6338 was a mistake because opening stdio:stdin with pkg/storage, closing it, and opening it again now returns a reader on which reads always fail with "read /dev/stdin: file already closed". Hide os.Stdin.Close again to prevent that error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StdioEngine.Get wraps os.Stdin with io.NopCloser and notSupportedReaderAt to hide its Close and ReadAt methods. This doesn't appear to be necessary, and exposing ReadAt enables reading CSUP and Parquet files from standard input.