change GET /query/describe to send aggregate input keys #6370
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GET /query/describe route sends a response containing the output keys for aggregation operations but Zui is interested in the input keys, so send those instead. This wasn't a problem for Zui for most queries until #6263, which changed the output key for "aggregate by a.b" from a.b (the path of the input key) to b (the last path component of the input key).
philrz
approved these changes
Nov 17, 2025
Contributor
philrz
left a comment
philrz
left a comment
There was a problem hiding this comment.
Normally I hold back on clicking Approve on such PRs, but I the fix seems simple and I just confirmed it's effective. I'm not offended if you want to wait for a second approval from a proper Go developer, though.
mattnibs
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GET /query/describe route sends a response containing the output keys for aggregation operations but Zui is interested in the input keys, so send those instead.
This wasn't a problem for Zui for most queries until #6263, which changed the output key for "aggregate by a.b" from a.b (the path of the input key) to b (the last path component of the input key).
Fixes brimdata/zui#3210.