Skip to content

Reformat count operator #6432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattnibs merged 1 commit into from
Dec 10, 2025
Merged

Reformat count operator #6432

mattnibs merged 1 commit into from
Dec 10, 2025

Conversation

@mattnibs
Copy link
Collaborator

@mattnibs mattnibs commented Dec 9, 2025 •
edited by philrz
Loading

This commit reformats the count operator so the record expression is no longer required and the count alias in the record expression is now the last argument.

Closes #6413

@mattnibs mattnibs requested a review from a team December 9, 2025 20:47
@mattnibs mattnibs force-pushed the countop-redux branch 2 times, most recently from a14e157 to d053f6e Compare December 9, 2025 21:08
@philrz
Copy link
Contributor

philrz commented Dec 9, 2025

I just tested out this branch at commit d053f6e and it matches the details captured in #6413 from the last time we discussed the specifics as a team, so it's a functional 👍 for me.

Also, assuming this merges, I'm game to write up the user-facing doc for it.

nwt
nwt reviewed Dec 10, 2025
View reviewed changes
@mattnibs mattnibs force-pushed the countop-redux branch 2 times, most recently from 1cccdff to f54e437 Compare December 10, 2025 17:05
@mattnibs
Reformat count operator
7bf8afd 
This commit reformats the count operator so the record expression is no
longer required and the count alias in the record expression is now the
last argument.
@mattnibs mattnibs requested a review from nwt December 10, 2025 17:07
nwt
nwt approved these changes Dec 10, 2025
View reviewed changes
Copy link
Member

@nwt nwt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. :shipit:

@mattnibs mattnibs merged commit 1c2b4e0 into main Dec 10, 2025
2 checks passed
@mattnibs mattnibs deleted the countop-redux branch December 10, 2025 17:13
@philrz philrz mentioned this pull request Dec 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nwt nwt nwt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

count operator without argument

4 participants

@mattnibs @philrz @nwt