Skip to content

vam: Fix incorrect null length when divide by zero #6473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattnibs merged 1 commit into from
Dec 29, 2025
Merged

vam: Fix incorrect null length when divide by zero #6473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions runtime/vam/expr/arith.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func (a *Arith) evalDivideByZero(kind vector.Kind, lhs, rhs vector.Any) vector.A
l, lnull := vector.IntValue(lhs, i)
r, rnull := vector.IntValue(rhs, i)
if lnull || rnull {
nulls.Set(i)
nulls.Set(uint32(len(ints)))
ints = append(ints, 0)
continue
}
Expand All @@ -113,6 +113,7 @@ func (a *Arith) evalDivideByZero(kind vector.Kind, lhs, rhs vector.Any) vector.A
ints = append(ints, l%r)
}
}
nulls.Shorten(uint32(len(ints)))
out = vector.NewInt(super.TypeInt64, ints, nulls)
case vector.KindUint:
var uints []uint64
Expand All @@ -121,7 +122,7 @@ func (a *Arith) evalDivideByZero(kind vector.Kind, lhs, rhs vector.Any) vector.A
l, lnull := vector.UintValue(lhs, i)
r, rnull := vector.UintValue(rhs, i)
if lnull || rnull {
nulls.Set(i)
nulls.Set(uint32(len(uints)))
uints = append(uints, 0)
continue
}
Expand All @@ -135,6 +136,7 @@ func (a *Arith) evalDivideByZero(kind vector.Kind, lhs, rhs vector.Any) vector.A
uints = append(uints, l%r)
}
}
nulls.Shorten(uint32(len(uints)))
out = vector.NewUint(super.TypeUint64, uints, nulls)
default:
panic(kind)
Expand Down