Skip to content

Added "A Dance with Dragons" by George R.R. Martin, Issue #43#102

Open
NotARossFan wants to merge 2 commits intobrittanyrw:masterfrom
NotARossFan:master
Open

Added "A Dance with Dragons" by George R.R. Martin, Issue #43#102
NotARossFan wants to merge 2 commits intobrittanyrw:masterfrom
NotARossFan:master

Conversation

@NotARossFan
Copy link
Contributor

@NotARossFan NotARossFan commented Sep 25, 2019

  • 🔍 I have checked to make sure that there is not already a pull request for the show/movie that I want to add.
  • 👍 My pull request has a descriptive title (such as Added Matilda or Added all of Jane Austen's books)
  • 🕵🏽‍♀️ I have searched the data.js file and confirmed I am not adding a duplicate entry.
  • 🖍️ I have placed the new books(s) or play(s) in alphabetical order based on title inside of the data.js file.
  • 3️⃣ I have at least four emojis listed under emojiImgs
  • [ X ] 5️⃣ I have a maximum of six emojis listed under emojiImgs.
  • ⭐ My genres are all inside of square brackets [ ] and each are individually wrapped in quotation marks and have a comma between each one. (such as submitting this "genres": ["fantasy", "children", "adventure"] and not this "genres":["fantasy, children, adventure"]).
  • 💜 I have used genres from this genre.md file or if I want to use genres not in this file already, I have added them to this file in alphabetical order.
  • 📅 I have added a single year under year.

Closes #43

@brittanyrw
Copy link
Owner

@NotARossFan It looks like this pull request only has "Of Mice and Men" updated and not "A Dance with Dragons". Could you update it to include "A Dance with Dragons"? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "A Dance with Dragons" by George R. R. Martin to EmojiPages

2 participants