[Needs Review] implementing backward compatible follow multi-target#30
Open
dev-masih wants to merge 1 commit intobritzl:masterfrom
dev-masih:master
Open
[Needs Review] implementing backward compatible follow multi-target#30dev-masih wants to merge 1 commit intobritzl:masterfrom dev-masih:master
dev-masih wants to merge 1 commit intobritzl:masterfrom
dev-masih:master
Conversation
Owner
|
I like the idea and the implementation makes sense I think. Do you have any additional thoughts or any concerns with the proposed solution? |
Contributor
Author
not until table support for go property gets added to the engine. |
Contributor
Author
|
@britzl if you think this implementation is fine, tell me so that i begin to fix example and docs |
Owner
|
@dev-masih Yes, I like it. Please go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So what I did was move target tables to camera module instead of camera script but kept target properties inside camera script because removing it cases a big compatibility issue (forcing devs to select follow target only with code). but the value of this property ignores and inside camera script init function it's value will be sent to targets that's inside camera module.
the only issue is if someone changes the target property directly in the middle of the game with go property instead of using
followfunction call or msg, the changed value will not affect anythingand it needs a better example implementation