Codeloom 4 bedrock #1
Conversation
- Complete Inspector service wrapper with enable, status, findings, coverage, and disable operations - Hello example demonstrating account status checking - Interactive scenario showcasing Inspector workflow - Comprehensive test infrastructure with stubbing support - Metadata file for documentation generation
| @@ -0,0 +1,128 @@ | |||
| inspector_Enable: | |||
| title: Enable &Inspector; scanning | |||
There was a problem hiding this comment.
Same problem as previous versions, it is not using a valid entity name. Also, it appears to be missing the hello example.
| excerpts: | ||
| - description: Enable Inspector scanning for specified resource types. | ||
| snippet_tags: | ||
| - python.example_code.inspector.Enable |
There was a problem hiding this comment.
The Kiro version correctly put 3 snippets here: class, decl, and the action code. This one is missing the extra snippets.
| services: | ||
| inspector: {Disable} | ||
| inspector_Hello: | ||
| title: Hello &Inspector; |
There was a problem hiding this comment.
Oh, here is the hello example. It should have been at the top.
|
|
||
| try: | ||
| # Create Inspector wrapper | ||
| inspector_wrapper = InspectorWrapper.from_client() |
There was a problem hiding this comment.
Similar to the Kiro example, it shouldn't use the wrapper for the hello example, instead it should stand alone.
| if max_results: | ||
| params["maxResults"] = max_results | ||
|
|
||
| response = self.inspector_client.list_coverage(**params) |
There was a problem hiding this comment.
This is a paginated operation, it should use the paginator here.
|
|
||
| def usage_demo(): | ||
| """ | ||
| Shows how to use the InspectorWrapper class. |
There was a problem hiding this comment.
We prefer the scenario to be in a separate file, to be consistent with the rest of the library. Here it is included in the wrapper file.
| wrapper = InspectorWrapper.from_client() | ||
|
|
||
| try: | ||
| # Get account status |
There was a problem hiding this comment.
The scenario doesn't include all of the steps given in the spec.
| Stub functions that are used by the Amazon Inspector unit tests. | ||
| """ | ||
|
|
||
| from test_tools.example_stubber import ExampleStubber |
There was a problem hiding this comment.
It creates the stubber file, but does not add it to the stubber list in stubber_factory.py. It also didn't write any tests (but maybe that wasn't requested).
| @@ -0,0 +1,73 @@ | |||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
A README should have been created in the new service folder.
This pull request...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.